From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] rds: tcp: per-netns flag to stop new connection creation when rds-tcp is being dismantled
Date: Thu, 25 Jan 2018 13:21:54 -0500 [thread overview]
Message-ID: <20180125182154.GL18181@oracle.com> (raw)
In-Reply-To: <20180125.113801.866004415127757834.davem@davemloft.net>
On (01/25/18 11:38), David Miller wrote:
>
> Please have a look at:
>
> commit 4ee806d51176ba7b8ff1efd81f271d7252e03a1d
Thanks for pointing that one out..
The same tear-down sequence (rds_conn_destroy()) is currently used
for both module unload as well as netns delete. And at least for
init_net, the net->count will not be 0 in rds_tcp_destroy_conns()
so by itself check_net() is not enough.
But check_net() may simplify things (at the very least, accelerate the
"goto bail" paths) for the netns delete case, let me take a look and
get back.
--Sowmini
prev parent reply other threads:[~2018-01-25 18:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 21:03 [PATCH net-next] rds: tcp: per-netns flag to stop new connection creation when rds-tcp is being dismantled Sowmini Varadhan
2018-01-24 21:32 ` Santosh Shilimkar
2018-01-25 16:38 ` David Miller
2018-01-25 18:21 ` Sowmini Varadhan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125182154.GL18181@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).