From: David Miller <davem@davemloft.net>
To: baijiaju1990@gmail.com
Cc: viro@ZenIV.linux.org.uk, 3chas3@gmail.com,
linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] atm: firestream: Replace GFP_ATOMIC with GFP_KERNEL in fs_send
Date: Fri, 26 Jan 2018 11:10:15 -0500 (EST) [thread overview]
Message-ID: <20180126.111015.455737320290348169.davem@davemloft.net> (raw)
In-Reply-To: <d5697036-e9aa-67a1-a6f3-3a17940542d6@gmail.com>
From: Jia-Ju Bai <baijiaju1990@gmail.com>
Date: Fri, 26 Jan 2018 21:56:32 +0800
> My tool did not handle this situation of passing function pointer, and
> I will improve the tool...
Never automate these kinds of changes.
Actually audit the change fully _yourself_ as a human after the tool
indicates a possibility to you.
This is why most of your changes have bugs, you rely on the tool too
much.
next prev parent reply other threads:[~2018-01-26 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 8:00 [PATCH] atm: firestream: Replace GFP_ATOMIC with GFP_KERNEL in fs_send Jia-Ju Bai
2018-01-26 12:05 ` Al Viro
2018-01-26 13:56 ` Jia-Ju Bai
2018-01-26 14:17 ` Jia-Ju Bai
2018-01-26 16:10 ` David Miller
2018-01-26 16:10 ` David Miller [this message]
2018-01-26 16:07 ` David Miller
2018-01-26 16:17 ` Jia-Ju Bai
2018-01-26 17:08 ` Al Viro
2018-01-27 4:09 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126.111015.455737320290348169.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=3chas3@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).