From: David Miller <davem@davemloft.net>
To: stefanha@redhat.com
Cc: netdev@vger.kernel.org, decui@microsoft.com, jhansen@vmware.com
Subject: Re: [PATCH] VSOCK: set POLLOUT | POLLWRNORM for TCP_CLOSING
Date: Fri, 26 Jan 2018 11:17:01 -0500 (EST) [thread overview]
Message-ID: <20180126.111701.1618019241717200752.davem@davemloft.net> (raw)
In-Reply-To: <20180126114825.15817-1-stefanha@redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Fri, 26 Jan 2018 11:48:25 +0000
> select(2) with wfds but no rfds must return when the socket is shut down
> by the peer. This way userspace notices socket activity and gets -EPIPE
> from the next write(2).
>
> Currently select(2) does not return for virtio-vsock when a SEND+RCV
> shutdown packet is received. This is because vsock_poll() only sets
> POLLOUT | POLLWRNORM for TCP_CLOSE, not the TCP_CLOSING state that the
> socket is in when the shutdown is received.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Applied and queued up for -stable, thank you.
prev parent reply other threads:[~2018-01-26 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 11:48 [PATCH] VSOCK: set POLLOUT | POLLWRNORM for TCP_CLOSING Stefan Hajnoczi
2018-01-26 16:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126.111701.1618019241717200752.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=jhansen@vmware.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).