From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Brauner Subject: Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK Date: Fri, 26 Jan 2018 12:33:03 +0100 Message-ID: <20180126113302.mfik752wbyqcwtbj@gmail.com> References: <20180124142634.17766-1-christian.brauner@ubuntu.com> <20180125125905.ahqrlmods5v56ucv@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: netdev@vger.kernel.org, nicolas.dichtel@6wind.com To: jbenc@redhat.com Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:36263 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751321AbeAZLdI (ORCPT ); Fri, 26 Jan 2018 06:33:08 -0500 Received: from mail-wr0-f199.google.com ([209.85.128.199]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1ef2Fk-00070O-VC for netdev@vger.kernel.org; Fri, 26 Jan 2018 11:33:04 +0000 Received: by mail-wr0-f199.google.com with SMTP id v10so97650wrv.22 for ; Fri, 26 Jan 2018 03:33:04 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180125125905.ahqrlmods5v56ucv@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Jan 25, 2018 at 01:59:06PM +0100, Christian Brauner wrote: > On Wed, Jan 24, 2018 at 03:26:31PM +0100, Christian Brauner wrote: > > Hi, > > > > Based on the previous discussion this enables passing a IFLA_IF_NETNSID > > property along with RTM_SETLINK and RTM_DELLINK requests. The patch for > > RTM_NEWLINK will be sent out in a separate patch since there are more > > corner-cases to think about. > > > > Best, > > Christian > > > > Changelog 2018-01-24: > > * Preserve old behavior and report -ENODEV when either ifindex or ifname is > > provided and IFLA_GROUP is set. Spotted by Wolfgang Bumiller. > > > > Christian Brauner (3): > > rtnetlink: enable IFLA_IF_NETNSID in do_setlink() > > rtnetlink: enable IFLA_IF_NETNSID for RTM_SETLINK > > rtnetlink: enable IFLA_IF_NETNSID for RTM_DELLINK > > > > net/core/rtnetlink.c | 96 ++++++++++++++++++++++++++++++++++++++++------------ > > 1 file changed, 75 insertions(+), 21 deletions(-) > > > > -- > > 2.14.1 > > > > I've done more testing around enabling IFLA_IF_NETNSID for RTM_NEWLINK > as well and I think that the change is actually trivial. However, I > would like to wait before sending this patch out until we have agreed on > the patches for RTM_SETLINK and RTM_DELLINK in this series. Once we have > merged those I can just send another small commit. Or - if changes to > this patch series are required - I can just add it in a v2. Jiri, do you want that patch resent with the small commit for RTM_NEWLINK included or are you fine with sending it after this series? Thanks! Christian