From: John Fastabend <john.fastabend@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net, davejwatson@fb.com
Cc: netdev@vger.kernel.org, bhole_prashant_q7@lab.ntt.co.jp
Subject: [bpf-next PATCH v2 0/3] bpf: sockmap fixes
Date: Fri, 26 Jan 2018 10:14:14 -0800 [thread overview]
Message-ID: <20180126180844.13175.22244.stgit@john-Precision-Tower-5810> (raw)
A set of fixes for sockmap to resolve map/prog not being cleaned
up when maps are not cleaned up from the program side.
For this we pull in the ULP infrastructure to hook into the close()
hook of the sock layer. This seemed natural because we have additional
sockmap features (to add support for TX hooks) that will also use the
ULP infrastructure. This allows us to cleanup entries in the map when
socks are closed() and avoid trying to get the sk_state_change() hook
to fire in all cases.
The second issue resolved here occurs when users don't detach
programs. The gist is a refcnt issue resolved by implementing the
release callback. See patch for details.
For testing I ran both sample/sockmap and selftests bpf/test_maps.c.
Dave Watson ran TLS test suite on v1 version of the patches without
the put_module error path change.
v2 changes rebased onto bpf-next with the following small updates
Patch 1/3 Dave Watson pointed out that we should do a module put
in case future users use this with another ULP other than sockmap.
And module_put is a nop when owner = NULL (sockmap case) so no
harm here and code is more robust.
Patch 2/3 Be explicit and set user_visible to false just to avoid
any reader confusion.
---
John Fastabend (3):
net: add a UID to use for ULP socket assignment
bpf: sockmap, add sock close() hook to remove socks
bpf: sockmap, fix leaking maps with attached but not detached progs
include/net/tcp.h | 8 ++
kernel/bpf/sockmap.c | 165 ++++++++++++++++++++++++++++----------------------
net/ipv4/tcp_ulp.c | 57 ++++++++++++++++-
net/tls/tls_main.c | 2 +
4 files changed, 155 insertions(+), 77 deletions(-)
next reply other threads:[~2018-01-26 18:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 18:14 John Fastabend [this message]
2018-01-26 18:14 ` [bpf-next PATCH v2 1/3] net: add a UID to use for ULP socket assignment John Fastabend
2018-01-26 18:14 ` [bpf-next PATCH v2 2/3] bpf: sockmap, add sock close() hook to remove socks John Fastabend
2018-01-26 21:02 ` John Fastabend
2018-01-26 18:14 ` [bpf-next PATCH v2 3/3] bpf: sockmap, fix leaking maps with attached but not detached progs John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126180844.13175.22244.stgit@john-Precision-Tower-5810 \
--to=john.fastabend@gmail.com \
--cc=ast@kernel.org \
--cc=bhole_prashant_q7@lab.ntt.co.jp \
--cc=daniel@iogearbox.net \
--cc=davejwatson@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox