* [PATCH bpf-next] bpf: clean up from test_tcpbpf_kern.c
@ 2018-01-26 20:06 Lawrence Brakmo
2018-01-26 22:44 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: Lawrence Brakmo @ 2018-01-26 20:06 UTC (permalink / raw)
To: netdev; +Cc: Kernel Team, Blake Matheny, Alexei Starovoitov, Daniel Borkmann
Removed commented lines from test_tcpbpf_kern.c
Fixes: d6d4f60c3a09 bpf: add selftest for tcpbpf
Signed-off-by: Lawrence Brakmo <brakmo@fb.com>
---
tools/testing/selftests/bpf/test_tcpbpf_kern.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/bpf/test_tcpbpf_kern.c b/tools/testing/selftests/bpf/test_tcpbpf_kern.c
index 66bf715..57119ad 100644
--- a/tools/testing/selftests/bpf/test_tcpbpf_kern.c
+++ b/tools/testing/selftests/bpf/test_tcpbpf_kern.c
@@ -79,9 +79,6 @@ int bpf_testcb(struct bpf_sock_ops *skops)
}
break;
case BPF_SOCK_OPS_PASSIVE_ESTABLISHED_CB:
- /* Set callback */
-// good_call_rv = bpf_sock_ops_cb_flags_set(skops,
-// BPF_SOCK_OPS_STATE_CB_FLAG);
skops->sk_txhash = 0x12345f;
v = 0xff;
rv = bpf_setsockopt(skops, SOL_IPV6, IPV6_TCLASS, &v,
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] bpf: clean up from test_tcpbpf_kern.c
2018-01-26 20:06 [PATCH bpf-next] bpf: clean up from test_tcpbpf_kern.c Lawrence Brakmo
@ 2018-01-26 22:44 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2018-01-26 22:44 UTC (permalink / raw)
To: Lawrence Brakmo, netdev; +Cc: Kernel Team, Blake Matheny, Alexei Starovoitov
On 01/26/2018 09:06 PM, Lawrence Brakmo wrote:
> Removed commented lines from test_tcpbpf_kern.c
>
> Fixes: d6d4f60c3a09 bpf: add selftest for tcpbpf
> Signed-off-by: Lawrence Brakmo <brakmo@fb.com>
Applied to bpf-next, thanks Lawrence!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-26 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-26 20:06 [PATCH bpf-next] bpf: clean up from test_tcpbpf_kern.c Lawrence Brakmo
2018-01-26 22:44 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).