From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net] ipv6: addrconf: break critical section in
 addrconf_verify_rtnl()
Date: Sat, 27 Jan 2018 10:52:50 +0200
Message-ID: <20180127085250.GA24639@splinter>
References: <e8a4b3ff-fee7-d790-8adf-2b9c3fe5b5f1@gmail.com>
 <20180120133753.GA27861@splinter>
 <1516474143.3478.2.camel@gmail.com>
 <20180120191959.GA5010@splinter>
 <30e8683f-eeb2-0b01-c12b-538c91ab8e93@gmail.com>
 <20180123180127.GA1765@splinter>
 <1516732983.3715.6.camel@gmail.com>
 <1517011843.3715.68.camel@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37253 "EHLO
        out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751446AbeA0Iw5 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 27 Jan 2018 03:52:57 -0500
Content-Disposition: inline
In-Reply-To: <1517011843.3715.68.camel@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Jan 26, 2018 at 04:10:43PM -0800, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> Heiner reported a lockdep splat [1]
> 
> This is caused by attempting GFP_KERNEL allocation while RCU lock is
> held and BH blocked.
> 
> We believe that addrconf_verify_rtnl() could run for a long period,
> so instead of using GFP_ATOMIC here as Ido suggested, we should break
> the critical section and restart it after the allocation.

[...]

> Fixes: f3d9832e56c4 ("ipv6: addrconf: cleanup locking in ipv6_add_addr")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Ido Schimmel <idosch@mellanox.com>

Thanks!