From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: dsahern@gmail.com, oss-drivers@netronome.com, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ip: address: fix stats64 JSON object name
Date: Sat, 27 Jan 2018 16:08:09 -0800 [thread overview]
Message-ID: <20180127160809.55824c11@xeon-e3> (raw)
In-Reply-To: <20180126193035.27338-1-jakub.kicinski@netronome.com>
On Fri, 26 Jan 2018 11:30:35 -0800
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> The JSON object name for statistics in ip link show is "stats644".
> Looks like a typo, commit d0e720111aad ("ip: ipaddress.c: add support
> for json output") contains an example with the expected "stats64" name.
>
> The fact that no one has noticed until now is probably an indication
> that no one is using this object. Hopefully it's not too late to fix
> this, although IIUC this has already been in 4.13 and 4.14 releases :S
>
> Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> ip/ipaddress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index ba60125c1b78..67ac6bd31373 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -598,7 +598,7 @@ static void print_link_stats64(FILE *fp, const struct rtnl_link_stats64 *s,
> const struct rtattr *carrier_changes)
> {
> if (is_json_context()) {
> - open_json_object("stats644");
> + open_json_object("stats64");
>
> /* RX stats */
> open_json_object("rx");
Thanks for the bugfix. Applied.
prev parent reply other threads:[~2018-01-28 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 19:30 [PATCH iproute2] ip: address: fix stats64 JSON object name Jakub Kicinski
2018-01-28 0:08 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180127160809.55824c11@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).