From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] ip: address: fix stats64 JSON object name Date: Sat, 27 Jan 2018 16:08:09 -0800 Message-ID: <20180127160809.55824c11@xeon-e3> References: <20180126193035.27338-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dsahern@gmail.com, oss-drivers@netronome.com, netdev@vger.kernel.org To: Jakub Kicinski Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:41655 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718AbeA1AIN (ORCPT ); Sat, 27 Jan 2018 19:08:13 -0500 Received: by mail-pl0-f67.google.com with SMTP id q3so1172851plr.8 for ; Sat, 27 Jan 2018 16:08:13 -0800 (PST) In-Reply-To: <20180126193035.27338-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 26 Jan 2018 11:30:35 -0800 Jakub Kicinski wrote: > The JSON object name for statistics in ip link show is "stats644". > Looks like a typo, commit d0e720111aad ("ip: ipaddress.c: add support > for json output") contains an example with the expected "stats64" name. > > The fact that no one has noticed until now is probably an indication > that no one is using this object. Hopefully it's not too late to fix > this, although IIUC this has already been in 4.13 and 4.14 releases :S > > Fixes: d0e720111aad ("ip: ipaddress.c: add support for json output") > Signed-off-by: Jakub Kicinski > --- > ip/ipaddress.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ip/ipaddress.c b/ip/ipaddress.c > index ba60125c1b78..67ac6bd31373 100644 > --- a/ip/ipaddress.c > +++ b/ip/ipaddress.c > @@ -598,7 +598,7 @@ static void print_link_stats64(FILE *fp, const struct rtnl_link_stats64 *s, > const struct rtattr *carrier_changes) > { > if (is_json_context()) { > - open_json_object("stats644"); > + open_json_object("stats64"); > > /* RX stats */ > open_json_object("rx"); Thanks for the bugfix. Applied.