From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: dsahern@gmail.com, jiri@resnulli.us, netdev@vger.kernel.org,
oss-drivers@netronome.com
Subject: Re: [PATCH iproute2] tc: fix second printing of requeues
Date: Sat, 27 Jan 2018 16:08:33 -0800 [thread overview]
Message-ID: <20180127160833.3980cd52@xeon-e3> (raw)
In-Reply-To: <20180127091904.6772-1-jakub.kicinski@netronome.com>
On Sat, 27 Jan 2018 01:19:04 -0800
Jakub Kicinski <jakub.kicinski@netronome.com> wrote:
> Non-JSON tc qdisc output used to print the "requeues" statistic
> twice. Commit 4fcec7f3665b ("tc: jsonify stats2") tried to preserve
> this behaviour for both standard output and JSON, but used the wrong
> statistic (q.qlen). Also duplicating keys in JSON is not allowed,
> so the second occurrence should be completely skipped with JSON.
>
> Fixes: 4fcec7f3665b ("tc: jsonify stats2")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Also applied this fix
prev parent reply other threads:[~2018-01-28 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 9:19 [PATCH iproute2] tc: fix second printing of requeues Jakub Kicinski
2018-01-28 0:08 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180127160833.3980cd52@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox