From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC 0/2] hv_netvsc shutdown redo Date: Sat, 27 Jan 2018 17:34:05 -0800 Message-ID: <20180127173405.541b135c@xeon-e3> References: <20180127001814.11203-1-sthemmin@microsoft.com> <87h8r7s261.fsf@vitty.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Vitaly Kuznetsov , KY Srinivasan , "mgamal@redhat.com" , "netdev@vger.kernel.org" , Stephen Hemminger To: Haiyang Zhang Return-path: Received: from mail-pl0-f54.google.com ([209.85.160.54]:36041 "EHLO mail-pl0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751452AbeA1BeI (ORCPT ); Sat, 27 Jan 2018 20:34:08 -0500 Received: by mail-pl0-f54.google.com with SMTP id v3so1232747plg.3 for ; Sat, 27 Jan 2018 17:34:08 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 27 Jan 2018 21:00:12 +0000 Haiyang Zhang wrote: > In the functions, set_channels and change_mtu, we used to call netvsc_close which has a wait for ring buffers to drain. Now, we call rndis_filter_close() directly without the wait for rings to drain. Could this be a problem? > rndis_filter_close now waits for rings to drain.