* [PATCH net-next] net/rocker: Remove unreachable return instruction
@ 2018-01-28 13:54 Leon Romanovsky
2018-01-28 15:15 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Leon Romanovsky @ 2018-01-28 13:54 UTC (permalink / raw)
To: Jiri Pirko, David S . Miller
Cc: linux-netdev, Arkadi Sharshevsky, Leon Romanovsky
From: Leon Romanovsky <leonro@mellanox.com>
The "return 0" instruction follows other return instruction
and it makes it impossible to execute, hence remove it.
Fixes: 00fc0c51e35b ("rocker: Change world_ops API and implementation to be switchdev independant")
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
drivers/net/ethernet/rocker/rocker_ofdpa.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/rocker/rocker_ofdpa.c b/drivers/net/ethernet/rocker/rocker_ofdpa.c
index 6d6fb8cf3e7c..6473cc68c2d5 100644
--- a/drivers/net/ethernet/rocker/rocker_ofdpa.c
+++ b/drivers/net/ethernet/rocker/rocker_ofdpa.c
@@ -789,7 +789,6 @@ static int ofdpa_flow_tbl_add(struct ofdpa_port *ofdpa_port,
ofdpa_flags_nowait(flags),
ofdpa_cmd_flow_tbl_add,
found, NULL, NULL);
- return 0;
}
static int ofdpa_flow_tbl_del(struct ofdpa_port *ofdpa_port,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net/rocker: Remove unreachable return instruction
2018-01-28 13:54 [PATCH net-next] net/rocker: Remove unreachable return instruction Leon Romanovsky
@ 2018-01-28 15:15 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-01-28 15:15 UTC (permalink / raw)
To: leon; +Cc: jiri, netdev, arkadis, leonro
From: Leon Romanovsky <leon@kernel.org>
Date: Sun, 28 Jan 2018 15:54:38 +0200
> From: Leon Romanovsky <leonro@mellanox.com>
>
> The "return 0" instruction follows other return instruction
> and it makes it impossible to execute, hence remove it.
>
> Fixes: 00fc0c51e35b ("rocker: Change world_ops API and implementation to be switchdev independant")
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-28 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-28 13:54 [PATCH net-next] net/rocker: Remove unreachable return instruction Leon Romanovsky
2018-01-28 15:15 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).