From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: linux-net-drivers@solarflare.com, netdev@vger.kernel.org,
fengguang.wu@intel.com, kbuild-all@01.org,
bkenward@solarflare.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] sfc: mark some unexported symbols as static
Date: Sun, 28 Jan 2018 21:59:41 -0500 (EST) [thread overview]
Message-ID: <20180128.215941.538757759630054496.davem@davemloft.net> (raw)
In-Reply-To: <c369f823-5271-5819-bde9-59f406359db7@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Fri, 26 Jan 2018 17:00:39 +0000
> From: kbuild test robot <fengguang.wu@intel.com>
>
> efx_default_channel_want_txqs() is only used in efx.c, while
> efx_ptp_want_txqs() and efx_ptp_channel_type (a struct) are only used
> in ptp.c. In all cases these symbols should be static.
>
> Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> [ecree@solarflare.com: rewrote commit message]
> Signed-off-by: Edward Cree <ecree@solarflare.com>
Applied, thanks Edward.
prev parent reply other threads:[~2018-01-29 2:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 1:03 [net-next:master 1913/1931] drivers/net/ethernet/sfc/efx.c:899:6: sparse: symbol 'efx_default_channel_want_txqs' was not declared. Should it be static? kbuild test robot
2018-01-26 1:03 ` [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static kbuild test robot
2018-01-26 15:13 ` Edward Cree
2018-01-26 16:13 ` David Miller
2018-01-26 17:00 ` [PATCH net-next] sfc: mark some unexported symbols as static Edward Cree
2018-01-29 2:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180128.215941.538757759630054496.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bkenward@solarflare.com \
--cc=ecree@solarflare.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).