From: Al Viro <viro@ZenIV.linux.org.uk>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ipv4: Get the address of interface correctly.
Date: Sun, 28 Jan 2018 14:44:58 +0000 [thread overview]
Message-ID: <20180128144457.GH13338@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20180128141907.GG13338@ZenIV.linux.org.uk>
On Sun, Jan 28, 2018 at 02:19:08PM +0000, Al Viro wrote:
> On Sun, Jan 28, 2018 at 03:38:58AM -0800, Tonghao Zhang wrote:
> > When using ioctl to get address of interface, we can't
> > get it anymore. For example, the command is show as below.
> >
> > # ifconfig eth0
> >
> > In the patch ("03aef17bb79b3"), the devinet_ioctl does not
> > return a suitable value, even though we can find it in
> > the kernel. Then fix it now.
>
> D'oh...
>
> Acked-by: Al Viro <viro@zeniv.linux.org.uk>
>
> I really wonder how has that avoided loud screams at boot time...
... and looks like LTP doesn't catch that either - none of these
ioctl is ever mentioned in the source, at least (of all SIOCS...
it only tries SIOCSIFFLAGS). Is there any testsuite that would
cover net ioctls?
next prev parent reply other threads:[~2018-01-28 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 11:38 [PATCH] ipv4: Get the address of interface correctly Tonghao Zhang
2018-01-28 14:19 ` Al Viro
2018-01-28 14:44 ` Al Viro [this message]
2018-01-29 19:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180128144457.GH13338@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).