From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sowmini Varadhan Subject: Re: [PATCH net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case Date: Sun, 28 Jan 2018 14:57:26 -0500 Message-ID: <20180128195726.GD22885@oracle.com> References: <20180128161851.GC22885@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Network Development , David Miller , rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com To: Willem de Bruijn Return-path: Received: from aserp2130.oracle.com ([141.146.126.79]:37656 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbeA1T5g (ORCPT ); Sun, 28 Jan 2018 14:57:36 -0500 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On (01/28/18 19:39), Willem de Bruijn wrote: > > But the whole test program is rather simplistic, since it doesnt > > actually verify the value of the cookies (hopefully me pending : > It might be nice to at least increment the variable on each > successful send. The test is single threaded anyway. And > then we can test that the returned values are in the defined > range. Yeah one thought that went through my head was that since I now pick the cookes as consecutive numbers (1..N) anyway, we could do a very simple-minded checksum on recv_completion notification to check that the sum of all the cookie values returned is actually N * (N+1)/2 - and flag errors/warnings if it is not.. this would be a test enhancement I could do later.. first let me try to avoid having all this complex timer-triggered code. --Sowmini