From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ipv6: change route cache aging logic Date: Mon, 29 Jan 2018 14:23:05 -0500 (EST) Message-ID: <20180129.142305.76893465926301867.davem@davemloft.net> References: <20180126194017.48018-1-tracywwnj@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, edumazet@google.com, kafai@fb.com, pabeni@redhat.com To: weiwan@google.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:48488 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbeA2TXH (ORCPT ); Mon, 29 Jan 2018 14:23:07 -0500 In-Reply-To: <20180126194017.48018-1-tracywwnj@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Wei Wang Date: Fri, 26 Jan 2018 11:40:17 -0800 > From: Wei Wang > > In current route cache aging logic, if a route has both RTF_EXPIRE and > RTF_GATEWAY set, the route will only be removed if the neighbor cache > has no RTN_ROUTE flag. Otherwise, even if the route has expired, it > won't get deleted. > Fix this logic to always check if the route has expired first and then > do the gateway neighbor cache check if previous check decide to not > remove the exception entry. > > Fixes: 1859bac04fb6 ("ipv6: remove from fib tree aged out RTF_CACHE dst") > Signed-off-by: Wei Wang > Signed-off-by: Eric Dumazet Applied and queued up for -stable, thanks.