From: David Miller <davem@davemloft.net>
To: amonakov@ispras.ru
Cc: netdev@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
sebastian.hesselbarth@gmail.com, f.fainelli@gmail.com
Subject: Re: [PATCH] net: pxa168_eth: add netconsole support
Date: Mon, 29 Jan 2018 14:31:56 -0500 (EST) [thread overview]
Message-ID: <20180129.143156.655708172616800160.davem@davemloft.net> (raw)
In-Reply-To: <20180127202907.23935-1-amonakov@ispras.ru>
From: Alexander Monakov <amonakov@ispras.ru>
Date: Sat, 27 Jan 2018 23:29:07 +0300
> @@ -1362,6 +1362,14 @@ static int pxa168_eth_do_ioctl(struct net_device *dev, struct ifreq *ifr,
> return -EOPNOTSUPP;
> }
>
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +static void pxa168_eth_netpoll(struct net_device *dev)
> +{
> + struct pxa168_eth_private *pep = netdev_priv(dev);
> + napi_schedule(&pep->napi);
> +}
> +#endif
This definitely is not sufficient.
Look at what other drivers do.
You have to invoke the interrupt handler with the device's interrupts disabled,
collect the events, and most importantly mask chip interrupts before scheduling
the NAPI instance.
Thank you.
next prev parent reply other threads:[~2018-01-29 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 20:29 [PATCH] net: pxa168_eth: add netconsole support Alexander Monakov
2018-01-29 19:31 ` David Miller [this message]
2018-01-31 14:05 ` Alexander Monakov
2018-01-31 15:20 ` David Miller
2018-02-01 19:45 ` [PATCH v2] " Alexander Monakov
2018-02-01 20:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129.143156.655708172616800160.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amonakov@ispras.ru \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).