From: Daniel Axtens <dja@axtens.net>
To: netdev@vger.kernel.org
Cc: Daniel Axtens <dja@axtens.net>,
Manish.Chopra@cavium.com, Jason Wang <jasowang@redhat.com>,
Pravin Shelar <pshelar@ovn.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: [PATCH v3 0/2] bnx2x: disable GSO on too-large packets
Date: Tue, 30 Jan 2018 12:14:45 +1100 [thread overview]
Message-ID: <20180130011447.24916-1-dja@axtens.net> (raw)
We observed a case where a packet received on an ibmveth device had a
GSO size of around 10kB. This was forwarded by Open vSwitch to a bnx2x
device, where it caused a firmware assert. This is described in detail
at [0].
Ultimately we want a fix in the core, but that is very tricky to
backport. So for now, just stop the bnx2x driver from crashing.
When net-next re-opens I will send the fix to the core and a revert
for this.
Marcelo: I have left renaming skb_gso_validate_mtu() for the
next series.
Thanks,
Daniel
[0]: https://patchwork.ozlabs.org/patch/859410/
Cc: Manish.Chopra@cavium.com
Cc: Jason Wang <jasowang@redhat.com>
Cc: Pravin Shelar <pshelar@ovn.org>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Daniel Axtens (2):
net: create skb_gso_validate_mac_len()
bnx2x: disable GSO where gso_size is too big for hardware
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 9 ++++
include/linux/skbuff.h | 16 ++++++
net/core/skbuff.c | 65 +++++++++++++++++++-----
net/sched/sch_tbf.c | 10 ----
4 files changed, 76 insertions(+), 24 deletions(-)
--
2.14.1
next reply other threads:[~2018-01-30 1:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 1:14 Daniel Axtens [this message]
2018-01-30 1:14 ` [PATCH v3 1/2] net: create skb_gso_validate_mac_len() Daniel Axtens
2018-01-30 1:46 ` Eric Dumazet
2018-01-30 1:59 ` Eric Dumazet
2018-01-30 2:42 ` Daniel Axtens
2018-01-30 8:17 ` Marcelo Ricardo Leitner
2018-01-30 13:08 ` Daniel Axtens
2018-01-30 16:59 ` kbuild test robot
2018-01-30 17:00 ` kbuild test robot
2018-01-30 1:14 ` [PATCH v3 2/2] bnx2x: disable GSO where gso_size is too big for hardware Daniel Axtens
2018-01-30 8:20 ` [PATCH v3 0/2] bnx2x: disable GSO on too-large packets Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130011447.24916-1-dja@axtens.net \
--to=dja@axtens.net \
--cc=Manish.Chopra@cavium.com \
--cc=jasowang@redhat.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).