From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Axtens Subject: [PATCH v3 0/2] bnx2x: disable GSO on too-large packets Date: Tue, 30 Jan 2018 12:14:45 +1100 Message-ID: <20180130011447.24916-1-dja@axtens.net> Cc: Daniel Axtens , Manish.Chopra@cavium.com, Jason Wang , Pravin Shelar , Marcelo Ricardo Leitner To: netdev@vger.kernel.org Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:41546 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751448AbeA3BPp (ORCPT ); Mon, 29 Jan 2018 20:15:45 -0500 Received: by mail-pf0-f196.google.com with SMTP id c6so7112778pfi.8 for ; Mon, 29 Jan 2018 17:15:45 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: We observed a case where a packet received on an ibmveth device had a GSO size of around 10kB. This was forwarded by Open vSwitch to a bnx2x device, where it caused a firmware assert. This is described in detail at [0]. Ultimately we want a fix in the core, but that is very tricky to backport. So for now, just stop the bnx2x driver from crashing. When net-next re-opens I will send the fix to the core and a revert for this. Marcelo: I have left renaming skb_gso_validate_mtu() for the next series. Thanks, Daniel [0]: https://patchwork.ozlabs.org/patch/859410/ Cc: Manish.Chopra@cavium.com Cc: Jason Wang Cc: Pravin Shelar Cc: Marcelo Ricardo Leitner Daniel Axtens (2): net: create skb_gso_validate_mac_len() bnx2x: disable GSO where gso_size is too big for hardware drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 9 ++++ include/linux/skbuff.h | 16 ++++++ net/core/skbuff.c | 65 +++++++++++++++++++----- net/sched/sch_tbf.c | 10 ---- 4 files changed, 76 insertions(+), 24 deletions(-) -- 2.14.1