From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC PATCH 2/2] hv_netvsc: Change GPADL teardown order according to Hyper-V version Date: Tue, 30 Jan 2018 11:30:41 -0800 Message-ID: <20180130113041.43ce732f@xeon-e3> References: <1516700045-32142-1-git-send-email-mgamal@redhat.com> <1516700045-32142-3-git-send-email-mgamal@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: otubo@redhat.com, sthemmin@microsoft.com, netdev@vger.kernel.org, haiyangz@microsoft.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, vkuznets@redhat.com To: Mohammed Gamal Return-path: In-Reply-To: <1516700045-32142-3-git-send-email-mgamal@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org On Tue, 23 Jan 2018 10:34:05 +0100 Mohammed Gamal wrote: > Commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split") > introduced a regression causing VMs not to shutdown on pre-Wind2016 > hosts after netvsc_remove_device() is called. This was caused as the > GPADL teardown sequence was changed. > > This patch restores the old behavior for pre-Win2016 hosts, while > keeping the changes from 0cf7378 for Win2016 and higher hosts. > > Signed-off-by: Mohammed Gamal Investigated the Windows driver to see how it handled this. It uses NVSP version < 4 to check for older hosts. So that patch should use that. Currently testing a version with that change.