From: David Miller <davem@davemloft.net>
To: amonakov@ispras.ru
Cc: netdev@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
sebastian.hesselbarth@gmail.com, f.fainelli@gmail.com
Subject: Re: [PATCH] net: pxa168_eth: add netconsole support
Date: Wed, 31 Jan 2018 10:20:39 -0500 (EST) [thread overview]
Message-ID: <20180131.102039.130340676906752608.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LNX.2.20.13.1801311638170.604@monopod.intra.ispras.ru>
From: Alexander Monakov <amonakov@ispras.ru>
Date: Wed, 31 Jan 2018 17:05:47 +0300 (MSK)
> And is this a matter of efficiency (not calling napi_schedule when there's
> nothing to do and not keeping interrupts enabled for its duration), or also
> a matter of correctness?
If you don't mask interrupts properly around scheduling and finishing
NAPI poll, you can lose events so it is a matter of correctness.
next prev parent reply other threads:[~2018-01-31 15:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-27 20:29 [PATCH] net: pxa168_eth: add netconsole support Alexander Monakov
2018-01-29 19:31 ` David Miller
2018-01-31 14:05 ` Alexander Monakov
2018-01-31 15:20 ` David Miller [this message]
2018-02-01 19:45 ` [PATCH v2] " Alexander Monakov
2018-02-01 20:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131.102039.130340676906752608.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amonakov@ispras.ru \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).