From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH] net: pxa168_eth: add netconsole support
Date: Wed, 31 Jan 2018 10:20:39 -0500 (EST)
Message-ID: <20180131.102039.130340676906752608.davem@davemloft.net>
References: <20180127202907.23935-1-amonakov@ispras.ru>
        <20180129.143156.655708172616800160.davem@davemloft.net>
        <alpine.LNX.2.20.13.1801311638170.604@monopod.intra.ispras.ru>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
        sebastian.hesselbarth@gmail.com, f.fainelli@gmail.com
To: amonakov@ispras.ru
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:44610 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751587AbeAaPUs (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 31 Jan 2018 10:20:48 -0500
In-Reply-To: <alpine.LNX.2.20.13.1801311638170.604@monopod.intra.ispras.ru>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Alexander Monakov <amonakov@ispras.ru>
Date: Wed, 31 Jan 2018 17:05:47 +0300 (MSK)

> And is this a matter of efficiency (not calling napi_schedule when there's
> nothing to do and not keeping interrupts enabled for its duration), or also
> a matter of correctness?

If you don't mask interrupts properly around scheduling and finishing
NAPI poll, you can lose events so it is a matter of correctness.