From: Dave Watson <davejwatson@fb.com>
To: Vakul Garg <vakul.garg@nxp.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"ilyal@mellanox.com" <ilyal@mellanox.com>,
"aviadye@mellanox.com" <aviadye@mellanox.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>
Subject: Re: [PATCHv2] tls: Add support for encryption using async offload accelerator
Date: Wed, 31 Jan 2018 09:34:44 -0800 [thread overview]
Message-ID: <20180131173444.GA41553@davejwatson-mba> (raw)
In-Reply-To: <HE1PR04MB30827E0097BB30E4E2EE51648BFB0@HE1PR04MB3082.eurprd04.prod.outlook.com>
On 01/31/18 05:22 PM, Vakul Garg wrote:
> > > On second though in stable we should probably just disable async tfm
> > > allocations.
> > > It's simpler. But this approach is still good for -next
> > >
> > >
> > > Gilad
> >
> > I agree with Gilad, just disable async for now.
> >
>
> How to do it? Can you help with the api name?
*aead = crypto_alloc_aead("gcm(aes)", 0, CRYPTO_ALG_ASYNC);
https://github.com/ktls/net_next_ktls/commit/f3b9b402e755e4b0623fa83f88137173fc249f2d
> > If the flag MSG_DONTWAIT is set, we should be returning -EINPROGRESS and
> > not wait for a response. I had started working on a patch for that, but it's
> > pretty tricky to get right.
>
> Can you point me to your WIP code branch for this?
https://github.com/ktls/net_next_ktls/commit/9cc839aa551ed972d148ecebf353b25ee93543b9
> If MSG_DONTWAIT is not used, will it be sane if enqueue the crypto request to
> accelerator and return to user space back so that user space can send more plaintext data while
> crypto accelerator is working in parallel?
Right, that's roughly what the above does. I believe the tricky
unfinished part was getting poll() to work correctly if there is an
async crypto request outstanding. Currently the tls poll() just
relies on backpressure from do_tcp_sendpages.
next prev parent reply other threads:[~2018-01-31 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 16:04 [PATCHv2] tls: Add support for encryption using async offload accelerator Vakul Garg
2018-01-31 15:22 ` Dave Watson
2018-01-31 17:22 ` Vakul Garg
2018-01-31 17:34 ` Dave Watson [this message]
2018-01-31 17:48 ` Gilad Ben-Yossef
2018-02-01 6:17 ` Vakul Garg
2018-01-31 15:33 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131173444.GA41553@davejwatson-mba \
--to=davejwatson@fb.com \
--cc=aviadye@mellanox.com \
--cc=davem@davemloft.net \
--cc=gilad@benyossef.com \
--cc=ilyal@mellanox.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).