From: David Miller <davem@davemloft.net>
To: dja@axtens.net
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
Manish.Chopra@cavium.com, jasowang@redhat.com, pshelar@ovn.org,
marcelo.leitner@gmail.com
Subject: Re: [PATCH v4 0/2] bnx2x: disable GSO on too-large packets
Date: Thu, 01 Feb 2018 09:36:22 -0500 (EST) [thread overview]
Message-ID: <20180201.093622.1451715802440909158.davem@davemloft.net> (raw)
In-Reply-To: <20180131031534.25166-1-dja@axtens.net>
From: Daniel Axtens <dja@axtens.net>
Date: Wed, 31 Jan 2018 14:15:32 +1100
> We observed a case where a packet received on an ibmveth device had a
> GSO size of around 10kB. This was forwarded by Open vSwitch to a bnx2x
> device, where it caused a firmware assert. This is described in detail
> at [0].
>
> Ultimately we want a fix in the core, but that is very tricky to
> backport. So for now, just stop the bnx2x driver from crashing.
>
> When net-next re-opens I will send the fix to the core and a revert
> for this.
>
> v4 changes:
> - fix compilation error with EXPORTs (patch 1)
> - only do slow test if gso_size is greater than 9000 bytes (patch 2)
...
> [0]: https://patchwork.ozlabs.org/patch/859410/
Series applied, thanks Daniel.
prev parent reply other threads:[~2018-02-01 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 3:15 [PATCH v4 0/2] bnx2x: disable GSO on too-large packets Daniel Axtens
2018-01-31 3:15 ` [PATCH v4 1/2] net: create skb_gso_validate_mac_len() Daniel Axtens
2018-01-31 3:15 ` [PATCH v4 2/2] bnx2x: disable GSO where gso_size is too big for hardware Daniel Axtens
2018-01-31 9:00 ` Chopra, Manish
2018-01-31 21:11 ` Daniel Axtens
2018-01-31 21:43 ` Eric Dumazet
2018-02-01 14:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201.093622.1451715802440909158.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Manish.Chopra@cavium.com \
--cc=dja@axtens.net \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).