From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: sathya.perla@broadcom.com, ajit.khaparde@broadcom.com,
sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] be2net: remove redundant initialization of 'head' and pointer txq
Date: Thu, 01 Feb 2018 09:43:17 -0500 (EST) [thread overview]
Message-ID: <20180201.094317.1226307518693749272.davem@davemloft.net> (raw)
In-Reply-To: <20180131161425.15011-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Wed, 31 Jan 2018 16:14:25 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable head is initialized to a value that is never read and is
> being updated to a new value a few lines later, hence this
> initialization is redundant and can be safely removed as well
> as the now unused pointer txq.
>
> Cleans up clang warning:
> drivers/net/ethernet/emulex/benet/be_main.c:996:6: warning: Value
> stored to 'head' during its initialization is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thank you.
prev parent reply other threads:[~2018-02-01 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 16:14 [PATCH] be2net: remove redundant initialization of 'head' and pointer txq Colin King
2018-02-01 14:43 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201.094317.1226307518693749272.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@broadcom.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).