From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] be2net: remove redundant initialization of 'head' and pointer txq Date: Thu, 01 Feb 2018 09:43:17 -0500 (EST) Message-ID: <20180201.094317.1226307518693749272.davem@davemloft.net> References: <20180131161425.15011-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20180131161425.15011-1-colin.king@canonical.com> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Wed, 31 Jan 2018 16:14:25 +0000 > From: Colin Ian King > > Variable head is initialized to a value that is never read and is > being updated to a new value a few lines later, hence this > initialization is redundant and can be safely removed as well > as the now unused pointer txq. > > Cleans up clang warning: > drivers/net/ethernet/emulex/benet/be_main.c:996:6: warning: Value > stored to 'head' during its initialization is never read > > Signed-off-by: Colin Ian King Applied, thank you.