From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net] tcp_bbr: fix pacing_gain to always be unity when
 using lt_bw
Date: Thu, 01 Feb 2018 09:44:22 -0500 (EST)
Message-ID: <20180201.094422.1284279400896772062.davem@davemloft.net>
References: <20180131204305.236274-1-ncardwell@google.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, ycheng@google.com, soheil@google.com
To: ncardwell@google.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:43860 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751467AbeBAOoX (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 1 Feb 2018 09:44:23 -0500
In-Reply-To: <20180131204305.236274-1-ncardwell@google.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Neal Cardwell <ncardwell@google.com>
Date: Wed, 31 Jan 2018 15:43:05 -0500

> This commit fixes the pacing_gain to remain at BBR_UNIT (1.0) when
> using lt_bw and returning from the PROBE_RTT state to PROBE_BW.
> 
> Previously, when using lt_bw, upon exiting PROBE_RTT and entering
> PROBE_BW the bbr_reset_probe_bw_mode() code could sometimes randomly
> end up with a cycle_idx of 0 and hence have bbr_advance_cycle_phase()
> set a pacing gain above 1.0. In such cases this would result in a
> pacing rate that is 1.25x higher than intended, potentially resulting
> in a high loss rate for a little while until we stop using the lt_bw a
> bit later.
> 
> This commit is a stable candidate for kernels back as far as 4.9.
> 
> Fixes: 0f8782ea1497 ("tcp_bbr: add BBR congestion control")
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
> Reported-by: Beyers Cronje <bcronje@gmail.com>

Applied and queued up for -stable, thanks Neal.