From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, mlxsw@mellanox.com
Subject: Re: [patch net] rocker: fix possible null pointer dereference in rocker_router_fib_event_work
Date: Thu, 01 Feb 2018 09:52:00 -0500 (EST) [thread overview]
Message-ID: <20180201.095200.5516558515183077.davem@davemloft.net> (raw)
In-Reply-To: <20180201112115.1315-1-jiri@resnulli.us>
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 1 Feb 2018 12:21:15 +0100
> From: Jiri Pirko <jiri@mellanox.com>
>
> Currently, rocker user may experience following null pointer
> derefence bug:
>
> [ 3.062141] BUG: unable to handle kernel NULL pointer dereference at 00000000000000d0
> [ 3.065163] IP: rocker_router_fib_event_work+0x36/0x110 [rocker]
>
> The problem is uninitialized rocker->wops pointer that is initialized
> only with the first initialized port. So move the port initialization
> before registering the fib events.
>
> Fixes: 936bd486564a ("rocker: use FIB notifications instead of switchdev calls")
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Applied and queued up for -stable, thanks Jiri.
prev parent reply other threads:[~2018-02-01 14:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 11:21 [patch net] rocker: fix possible null pointer dereference in rocker_router_fib_event_work Jiri Pirko
2018-02-01 14:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201.095200.5516558515183077.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).