From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] vmxnet3: remove redundant initialization of pointer 'rq' Date: Thu, 01 Feb 2018 14:54:56 -0500 (EST) Message-ID: <20180201.145456.251900509374837057.davem@davemloft.net> References: <20180201172921.22770-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: skhare@vmware.com, pv-drivers@vmware.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50028 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754594AbeBATy6 (ORCPT ); Thu, 1 Feb 2018 14:54:58 -0500 In-Reply-To: <20180201172921.22770-1-colin.king@canonical.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Colin King Date: Thu, 1 Feb 2018 17:29:21 +0000 > From: Colin Ian King > > Pointer rq is being initialized but this value is never read, it > is being updated inside a for-loop. Remove the initialization and > move it into the scope of the for-loop. > > Cleans up clang warning: > drivers/net/vmxnet3/vmxnet3_drv.c:2763:27: warning: Value stored > to 'rq' during its initialization is never read > > Signed-off-by: Colin Ian King Applied.