From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server Date: Thu, 01 Feb 2018 14:59:35 -0500 (EST) Message-ID: <20180201.145935.1511421104143236233.davem@davemloft.net> References: <20180201180430.16950-1-desnesn@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, tlfalcon@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com To: desnesn@linux.vnet.ibm.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50094 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754594AbeBAT7i (ORCPT ); Thu, 1 Feb 2018 14:59:38 -0500 In-Reply-To: <20180201180430.16950-1-desnesn@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Desnes Augusto Nunes do Rosario Date: Thu, 1 Feb 2018 16:04:30 -0200 > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the ethtool will be NULL. Therefore, > this patch fixes the firmware string and its warning. > > Fixes: 4e6759be28e4 ("ibmvnic: Feature implementation of VPD for the ibmvnic driver") > > Signed-off-by: Desnes A. Nunes do Rosario Applied. Please do not put empty lines between Fixes: and Signed-off-by: and other tags, all tags are equal and are placed together in an uninterrupted sequences of consequetive lines. Thank you.