From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: netdev@vger.kernel.org, oss-drivers@netronome.com,
edwin.peer@netronome.com
Subject: Re: [PATCH net] nfp: fix TLV offset calculation
Date: Fri, 02 Feb 2018 19:18:03 -0500 (EST) [thread overview]
Message-ID: <20180202.191803.1084758994655255624.davem@davemloft.net> (raw)
In-Reply-To: <20180202034143.14400-1-jakub.kicinski@netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 1 Feb 2018 19:41:43 -0800
> From: Edwin Peer <edwin.peer@netronome.com>
>
> The data pointer in the config space TLV parser already includes
> NFP_NET_CFG_TLV_BASE, it should not be added again. Incorrect
> offset values were only used in printed user output, rendering
> the bug merely cosmetic.
>
> Fixes: 73a0329b057e ("nfp: add TLV capabilities to the BAR")
> Signed-off-by: Edwin Peer <edwin.peer@netronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Applied, thanks Jakub.
prev parent reply other threads:[~2018-02-03 0:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 3:41 [PATCH net] nfp: fix TLV offset calculation Jakub Kicinski
2018-02-03 0:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202.191803.1084758994655255624.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edwin.peer@netronome.com \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).