From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] nfp: fix TLV offset calculation Date: Fri, 02 Feb 2018 19:18:03 -0500 (EST) Message-ID: <20180202.191803.1084758994655255624.davem@davemloft.net> References: <20180202034143.14400-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, edwin.peer@netronome.com To: jakub.kicinski@netronome.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:44814 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751669AbeBCASM (ORCPT ); Fri, 2 Feb 2018 19:18:12 -0500 In-Reply-To: <20180202034143.14400-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Kicinski Date: Thu, 1 Feb 2018 19:41:43 -0800 > From: Edwin Peer > > The data pointer in the config space TLV parser already includes > NFP_NET_CFG_TLV_BASE, it should not be added again. Incorrect > offset values were only used in printed user output, rendering > the bug merely cosmetic. > > Fixes: 73a0329b057e ("nfp: add TLV capabilities to the BAR") > Signed-off-by: Edwin Peer > Reviewed-by: Jakub Kicinski Applied, thanks Jakub.