From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] cls_u32: add missing RCU annotation. Date: Fri, 02 Feb 2018 19:26:26 -0500 (EST) Message-ID: <20180202.192626.1077550990238426722.davem@davemloft.net> References: <3dd4066d949fcfc928f61183c78e7ce0ab310063.1517582707.git.pabeni@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, john.fastabend@gmail.com To: pabeni@redhat.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:44910 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752755AbeBCA01 (ORCPT ); Fri, 2 Feb 2018 19:26:27 -0500 In-Reply-To: <3dd4066d949fcfc928f61183c78e7ce0ab310063.1517582707.git.pabeni@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Paolo Abeni Date: Fri, 2 Feb 2018 16:02:22 +0100 > In a couple of points of the control path, n->ht_down is currently > accessed without the required RCU annotation. The accesses are > safe, but sparse complaints. Since we already held the > rtnl lock, let use rtnl_dereference(). > > Fixes: a1b7c5fd7fe9 ("net: sched: add cls_u32 offload hooks for netdevs") > Fixes: de5df63228fc ("net: sched: cls_u32 changes to knode must appear atomic to readers") > Signed-off-by: Paolo Abeni Applied and queued up for -stable.