From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: [PATCH net] nfp: fix TLV offset calculation Date: Thu, 1 Feb 2018 19:41:43 -0800 Message-ID: <20180202034143.14400-1-jakub.kicinski@netronome.com> Cc: netdev@vger.kernel.org, oss-drivers@netronome.com, Edwin Peer To: davem@davemloft.net Return-path: Received: from mail-pl0-f67.google.com ([209.85.160.67]:38861 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751530AbeBBDmR (ORCPT ); Thu, 1 Feb 2018 22:42:17 -0500 Received: by mail-pl0-f67.google.com with SMTP id 13so5178285plb.5 for ; Thu, 01 Feb 2018 19:42:17 -0800 (PST) Sender: netdev-owner@vger.kernel.org List-ID: From: Edwin Peer The data pointer in the config space TLV parser already includes NFP_NET_CFG_TLV_BASE, it should not be added again. Incorrect offset values were only used in printed user output, rendering the bug merely cosmetic. Fixes: 73a0329b057e ("nfp: add TLV capabilities to the BAR") Signed-off-by: Edwin Peer Reviewed-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c index ffb402746ad4..1f9149bb2ae6 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ctrl.c @@ -65,7 +65,7 @@ int nfp_net_tlv_caps_parse(struct device *dev, u8 __iomem *ctrl_mem, u32 hdr = readl(data); length = FIELD_GET(NFP_NET_CFG_TLV_HEADER_LENGTH, hdr); - offset = data - ctrl_mem + NFP_NET_CFG_TLV_BASE; + offset = data - ctrl_mem; /* Advance past the header */ data += 4; -- 2.15.1