From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [RFC iproute2-next 00/16] iproute printing enhancements Date: Fri, 2 Feb 2018 14:24:55 -0800 Message-ID: <20180202142455.1d690516@xeon-e3> References: <20180202011946.21929-1-sthemmin@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Stephen Hemminger To: David Ahern Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:33575 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751468AbeBBWY6 (ORCPT ); Fri, 2 Feb 2018 17:24:58 -0500 Received: by mail-pf0-f193.google.com with SMTP id u15so1938041pfa.0 for ; Fri, 02 Feb 2018 14:24:58 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 1 Feb 2018 20:08:37 -0700 David Ahern wrote: > On 2/1/18 6:19 PM, Stephen Hemminger wrote: > > The first group of patches refactor the printout to breakup > > excessively long print_route function and the last few implement > > JSON and color output format for routes. > > > > The one thing that maybe controversial is changing the default > > json output format to be compact. The value of JSON is for programattic > > output therefore pretty-printing should be an option. > > > > One change I didn't make (but considered) is not calling fflush > > after every single entry. When dumping millions of routes, letting > > stdio buffer output would be a performance win. > > > > Stephen Hemminger (16): > > iproute: refactor printing flags > > iproute: make printing icmpv6 a function > > iproute: make printing IPv4 cache flags a function > > iproute: refactor cacheinfo printing > > iproute: refactor metrics print > > iproute: refactor printing flow info > > iproute2: refactor newdst, gateway and via printing > > iproute: refactor multipath print > > iproute: refactor printing of interface > > iproute: whitespace fixes > > iproute: don't do assignment in condition > > iproute: make flush a separate function > > iproute: implement JSON and color output > > json: make pretty printing optional > > man: add documentation for json and pretty flags > > json: fix newline at end of array > > > > The first 12 look fine to me; familiar territory. Why not send those > outside of the json patches which require a closer look? > When I submit final version, will break into three sets. First is refactoring (including doing flags better), then color/json. Lastly, the pretty print change.