From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] igmp: fix unsafe RCU usage in igmpv3_src_addr Date: Fri, 2 Feb 2018 17:04:41 -0800 Message-ID: <20180202170441.5d77150c@xeon-e3> References: <20180202213044.32747-1-sthemmin@microsoft.com> <1517609925.3715.140.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: nbd@nbd.name, davem@davemloft.net, netdev@vger.kernel.org To: Eric Dumazet Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:40734 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbeBCBEo (ORCPT ); Fri, 2 Feb 2018 20:04:44 -0500 Received: by mail-pg0-f68.google.com with SMTP id g16so14827928pgn.7 for ; Fri, 02 Feb 2018 17:04:44 -0800 (PST) In-Reply-To: <1517609925.3715.140.camel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, 02 Feb 2018 14:18:45 -0800 Eric Dumazet wrote: > On Fri, 2018-02-02 at 13:30 -0800, Stephen Hemminger wrote: > > From: Stephen Hemminger > > > > New igmpv3_get_src_addr would sometimes be called in receive path > > without holding RCU lock. > > Strange, this should have been fixed already ? > > https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=e7aadb27a5415e8125834b84a74477bfbee4eff5 Yes, that fixes it as well. Did not have that commit on my branch yet.