From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roman Gushchin Subject: Re: [PATCH net] Revert "defer call to mem_cgroup_sk_alloc()" Date: Fri, 2 Feb 2018 19:04:33 +0000 Message-ID: <20180202190426.GA15313@castle.DHCP.thefacebook.com> References: <20180202165754.8551-1-guro@fb.com> <1517594367.3715.130.camel@gmail.com> <20180202180624.GA11596@castle.DHCP.thefacebook.com> <1517596744.3715.137.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Eric Dumazet , , , , "David S . Miller" , Johannes Weiner , Tejun Heo To: Eric Dumazet Return-path: Content-Disposition: inline In-Reply-To: <1517596744.3715.137.camel@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, Feb 02, 2018 at 10:39:04AM -0800, Eric Dumazet wrote: > On Fri, 2018-02-02 at 18:06 +0000, Roman Gushchin wrote: > > > > Idk, how even we can hit it? And if so, what scary will happen? > > > > If you prefer to have it there, I definitely can return it, > > but I see no profit so far. > > I was simply curious this was not mentioned in the changelog. > > A revert is normally a true revert, modulo the changes needed by > conflicts and possible changes. > > I personally do not care of this BUG_ON(), I had not put it in the > first place. Technically it's not a true revert, but you're totally right. Let me add a note to the commit description. Are you ok with the rest? Thanks!