From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [bpf-next PATCH 0/5] tools/libbpf improvements and selftests Date: Sun, 4 Feb 2018 10:19:13 +0100 Message-ID: <20180204101913.2f0bcb0d@redhat.com> References: <151707400217.12604.5522514180508858186.stgit@firesoul> <8e21a7e5-c356-cfe8-c56e-aac45ed56afa@iogearbox.net> <20180201154127.17ec8996@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Daniel Borkmann , Alexei Starovoitov , wangnan0@huawei.com, acme@redhat.com, joe@ovn.org, jakub.kicinski@netronome.com, eric@regit.org, brouer@redhat.com To: Daniel Borkmann Return-path: Received: from mx1.redhat.com ([209.132.183.28]:46098 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbeBDJTW (ORCPT ); Sun, 4 Feb 2018 04:19:22 -0500 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 1 Feb 2018 18:56:14 +0100 Daniel Borkmann wrote: > Don't get me wrong, I'm not at all against such tool or test, I think > it's a great idea and needed. I just think that tools/lib/bpf/ is not > the right place to put it into lib directory. Right now, as you say, > it's a mixture of example code on how to use the lib, and tool at the > same time to dump/test load an object file with libbpf. Okay, to avoid polluting the directory of the library with test/samples programs, bow for your suggestion of moving the file to the selftests directory. I'm at FOSDEM now, and I cannot send a V2 patch right now... If you need this in fast (due merge timing), you can make the change yourself and apply it... else I'll send a V2 on Tuesday. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer