From: David Miller <davem@davemloft.net>
To: tommi.t.rantala@nokia.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
nhorman@tuxdriver.com, alexey.kodanev@oracle.com,
marcelo.leitner@gmail.com
Subject: Re: [PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst
Date: Mon, 05 Feb 2018 09:58:51 -0500 (EST) [thread overview]
Message-ID: <20180205.095851.568720869636736573.davem@davemloft.net> (raw)
In-Reply-To: <20180205133311.2620-1-tommi.t.rantala@nokia.com>
From: Tommi Rantala <tommi.t.rantala@nokia.com>
Date: Mon, 5 Feb 2018 15:33:11 +0200
> Fixes: 410f03831 ("sctp: add routing output fallback")
> Signed-off-by: Tommi Rantala <tommi.t.rantala@nokia.com>
I would add another Fixes tag mentioning commit:
0ca50d12fe46cdf3c0dc9ec5ca98607a52afdc62
("sctp: fix src address selection if using secondary addresses")
because it is another origin for this dst leak.
Otherwise your patch looks great, please respin it with a second
Fixes: tag added for the above commit and I'll apply this.
Thanks!
next prev parent reply other threads:[~2018-02-05 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 13:33 [PATCH net v2] sctp: fix dst refcnt leak in sctp_v4_get_dst Tommi Rantala
2018-02-05 14:58 ` David Miller [this message]
2018-02-05 15:47 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205.095851.568720869636736573.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.kodanev@oracle.com \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=tommi.t.rantala@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox