* [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default [not found] <20180205012146.23981-1-ulfalizer@gmail.com> @ 2018-02-05 1:21 ` Ulf Magnusson 2018-02-15 7:35 ` Luciano Coelho 0 siblings, 1 reply; 2+ messages in thread From: Ulf Magnusson @ 2018-02-05 1:21 UTC (permalink / raw) To: linux-kernel Cc: linux-kbuild, tfiga, paul.burton, m.szyprowski, egtvedt, linus.walleij, vgupta, mgorman, hch, mina86, robh, sboyd, paulus, will.deacon, tony, npiggin, yamada.masahiro, Ulf Magnusson, Johannes Berg, Emmanuel Grumbach, Luca Coelho, Intel Linux Wireless, Kalle Valo, linux-wireless, netdev 'default false' should be 'default n', though they happen to have the same effect here, due to undefined symbols ('false' in this case) evaluating to n in a tristate sense. Remove the default instead of changing it. bool and tristate symbols implicitly default to n. Discovered with the https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_undefined.py script. Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> --- drivers/net/wireless/intel/iwlwifi/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig index c5f2ddf9b0fe..e5a2fc738ac3 100644 --- a/drivers/net/wireless/intel/iwlwifi/Kconfig +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig @@ -91,7 +91,6 @@ config IWLWIFI_BCAST_FILTERING config IWLWIFI_PCIE_RTPM bool "Enable runtime power management mode for PCIe devices" depends on IWLMVM && PM && EXPERT - default false help Say Y here to enable runtime power management for PCIe devices. If enabled, the device will go into low power mode -- 2.14.1 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default 2018-02-05 1:21 ` [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default Ulf Magnusson @ 2018-02-15 7:35 ` Luciano Coelho 0 siblings, 0 replies; 2+ messages in thread From: Luciano Coelho @ 2018-02-15 7:35 UTC (permalink / raw) To: Ulf Magnusson, linux-kernel Cc: linux-kbuild, tfiga, paul.burton, m.szyprowski, egtvedt, linus.walleij, vgupta, mgorman, hch, mina86, robh, sboyd, paulus, will.deacon, tony, npiggin, yamada.masahiro, Johannes Berg, Emmanuel Grumbach, Intel Linux Wireless, Kalle Valo, linux-wireless, netdev On Mon, 2018-02-05 at 02:21 +0100, Ulf Magnusson wrote: > 'default false' should be 'default n', though they happen to have the > same effect here, due to undefined symbols ('false' in this case) > evaluating to n in a tristate sense. > > Remove the default instead of changing it. bool and tristate symbols > implicitly default to n. > > Discovered with the > https://github.com/ulfalizer/Kconfiglib/blob/master/examples/list_und > efined.py > script. > > Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com> > --- Thanks, Ulf! This is applied in our internal tree and will eventually reach the mainline, following our usual upstreaming process. -- Cheers, Luca. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-15 7:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180205012146.23981-1-ulfalizer@gmail.com>
2018-02-05 1:21 ` [PATCH 18/20] iwlwifi: fix malformed CONFIG_IWLWIFI_PCIE_RTPM default Ulf Magnusson
2018-02-15 7:35 ` Luciano Coelho
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).