From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Cc: Tomasz Torcz <tomasz.torcz@nordea.com>,
netdev@vger.kernel.org, tomek@pipebreaker.pl
Subject: Re: [PATCH] ss: introduce switch to print exact value of data rates
Date: Mon, 5 Feb 2018 17:02:27 -0800 [thread overview]
Message-ID: <20180205170227.1406931f@xeon-e3> (raw)
In-Reply-To: <7b955a90-788d-07be-19ef-64fb481022ee@gmail.com>
On Fri, 2 Feb 2018 16:32:47 -0700
David Ahern <dsahern@gmail.com> wrote:
> On 2/1/18 7:19 AM, Tomasz Torcz wrote:
> > Introduce -X/--exact switch to disable human-friendly printing
> > of datarates. With the switch, data is not presented as MBps/Kbps.
> >
> > Signed-off-by: Tomasz Torcz <tomasz.torcz@nordea.com>
> > ---
> > misc/ss.c | 12 ++++++++++--
> > 1 file changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/misc/ss.c b/misc/ss.c
> > index 29a25070..5ca5112a 100644
> > --- a/misc/ss.c
> > +++ b/misc/ss.c
> > @@ -95,6 +95,7 @@ int resolve_services = 1;
> > int preferred_family = AF_UNSPEC;
> > int show_options;
> > int show_details;
> > +int show_exact;
>
> show_exact suggests the other versions are not exact. show_raw? or
>
> int human_readable = 1;
>
> and -X disables it?
agree with david, think of another flag name (raw? or no-prefix?)
next prev parent reply other threads:[~2018-02-06 1:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 14:19 [PATCH] ss: introduce switch to print exact value of data rates Tomasz Torcz
2018-02-02 23:32 ` David Ahern
2018-02-06 1:02 ` Stephen Hemminger [this message]
2018-03-11 16:26 ` [PATCH v2] " Tomasz Torcz
2018-03-11 16:26 ` [PATCH] " Tomasz Torcz
2018-03-16 15:40 ` David Ahern
2019-07-01 11:52 ` [PATCH v3] " Tomasz Torcz
2019-07-01 14:51 ` David Ahern
2019-07-02 6:53 ` [PATCH] ss: in --numeric mode, print raw numbers for " Tomasz Torcz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205170227.1406931f@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tomasz.torcz@nordea.com \
--cc=tomek@pipebreaker.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).