From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-kernel@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
linux-renesas-soc@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
netdev@vger.kernel.org
Subject: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask
Date: Mon, 5 Feb 2018 21:09:57 +0100 [thread overview]
Message-ID: <20180205201002.23621-1-wsa+renesas@sang-engineering.com> (raw)
In one Renesas driver, I found a typo which turned an intended bit shift ('<<')
into a comparison ('<'). Because this is a subtle issue, I looked tree wide for
similar patterns. This small patch series is the outcome.
Buildbot and checkpatch are happy. Only compile-tested. To be applied
individually per sub-system, I think. I'd think only the net: amd: patch needs
to be conisdered for stable, but I leave this to people who actually know this
driver.
CCing Dan. Maybe he has an idea how to add a test to smatch? In my setup, only
cppcheck reported a 'coding style' issue with a low prio.
Wolfram Sang (4):
v4l: vsp1: fix mask creation for MULT_ALPHA_RATIO
drm/exynos: fix comparison to bitshift when dealing with a mask
v4l: dvb-frontends: stb0899: fix comparison to bitshift when dealing
with a mask
net: amd-xgbe: fix comparison to bitshift when dealing with a mask
drivers/gpu/drm/exynos/regs-fimc.h | 2 +-
drivers/media/dvb-frontends/stb0899_reg.h | 8 ++++----
drivers/media/platform/vsp1/vsp1_regs.h | 2 +-
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)
--
2.11.0
next reply other threads:[~2018-02-05 20:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 20:09 Wolfram Sang [this message]
2018-02-05 20:10 ` [PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask Wolfram Sang
2018-02-05 22:35 ` Tom Lendacky
2018-02-06 16:25 ` David Miller
2018-02-06 8:20 ` [PATCH 0/4] tree-wide: " Geert Uytterhoeven
2018-02-06 8:28 ` Wolfram Sang
2018-02-06 13:10 ` Dan Carpenter
2018-02-06 13:15 ` Julia Lawall
2018-02-06 13:23 ` Dan Carpenter
2018-02-06 13:40 ` Julia Lawall
2018-02-06 13:53 ` Wolfram Sang
2018-02-06 13:54 ` Julia Lawall
2018-02-06 13:57 ` Wolfram Sang
2018-02-06 13:59 ` Dan Carpenter
2018-02-06 14:08 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180205201002.23621-1-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).