From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: Regression in 39461af74125 "bitmap: replace bitmap_{from,to}_u32array" Date: Tue, 06 Feb 2018 11:17:36 -0500 (EST) Message-ID: <20180206.111736.1114727374069829674.davem@davemloft.net> References: <4ad95153-e9bf-ef0d-c81a-d8daab2e6d50@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ynorov@caviumnetworks.com, akpm@linux-foundation.org, sfr@canb.auug.org.au, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:45368 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752222AbeBFQRh (ORCPT ); Tue, 6 Feb 2018 11:17:37 -0500 In-Reply-To: <4ad95153-e9bf-ef0d-c81a-d8daab2e6d50@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Mon, 5 Feb 2018 07:21:32 +0100 > Recently ethtool started to give incomplete values for supported and > advertised modes. There seems to be a regression in this commit: > The bit number parameter in the calls to bitmap_to_arr32() in > store_link_ksettings_for_user() should be __ETHTOOL_LINK_MODE_MASK_NBITS > instead of __ETHTOOL_LINK_MODE_MASK_NU32. > > After having changed this ethtool behaves normally again. I do not see the commit with the SHA1 ID from the Subject line in either Linus's nor my networking tree. Where is that change? [davem@dhcp-10-15-49-227 linux]$ git show 39461af74125 >x.diff fatal: ambiguous argument '39461af74125': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' [davem@dhcp-10-15-49-227 linux]$ cd ../net [davem@dhcp-10-15-49-227 net]$ git show 39461af74125 >x.diff fatal: ambiguous argument '39461af74125': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' [davem@dhcp-10-15-49-227 net]$