* [PATCH v3] RDS: IB: Fix null pointer issue
@ 2018-02-05 2:27 Guanglei Li
2018-02-05 17:40 ` Doug Ledford
0 siblings, 1 reply; 4+ messages in thread
From: Guanglei Li @ 2018-02-05 2:27 UTC (permalink / raw)
To: santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA
Cc: guanglei.li-QHcLZuEGTsvQT0dZR+AlfA,
honglei.wang-QHcLZuEGTsvQT0dZR+AlfA,
junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA,
yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA
Scenario:
1. Port down and do fail over
2. Ap do rds_bind syscall
PID: 47039 TASK: ffff89887e2fe640 CPU: 47 COMMAND: "kworker/u:6"
#0 [ffff898e35f159f0] machine_kexec at ffffffff8103abf9
#1 [ffff898e35f15a60] crash_kexec at ffffffff810b96e3
#2 [ffff898e35f15b30] oops_end at ffffffff8150f518
#3 [ffff898e35f15b60] no_context at ffffffff8104854c
#4 [ffff898e35f15ba0] __bad_area_nosemaphore at ffffffff81048675
#5 [ffff898e35f15bf0] bad_area_nosemaphore at ffffffff810487d3
#6 [ffff898e35f15c00] do_page_fault at ffffffff815120b8
#7 [ffff898e35f15d10] page_fault at ffffffff8150ea95
[exception RIP: unknown or invalid address]
RIP: 0000000000000000 RSP: ffff898e35f15dc8 RFLAGS: 00010282
RAX: 00000000fffffffe RBX: ffff889b77f6fc00 RCX:ffffffff81c99d88
RDX: 0000000000000000 RSI: ffff896019ee08e8 RDI:ffff889b77f6fc00
RBP: ffff898e35f15df0 R8: ffff896019ee08c8 R9:0000000000000000
R10: 0000000000000400 R11: 0000000000000000 R12:ffff896019ee08c0
R13: ffff889b77f6fe68 R14: ffffffff81c99d80 R15: ffffffffa022a1e0
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
#8 [ffff898e35f15dc8] cma_ndev_work_handler at ffffffffa022a228 [rdma_cm]
#9 [ffff898e35f15df8] process_one_work at ffffffff8108a7c6
#10 [ffff898e35f15e58] worker_thread at ffffffff8108bda0
#11 [ffff898e35f15ee8] kthread at ffffffff81090fe6
PID: 45659 TASK: ffff880d313d2500 CPU: 31 COMMAND: "oracle_45659_ap"
#0 [ffff881024ccfc98] __schedule at ffffffff8150bac4
#1 [ffff881024ccfd40] schedule at ffffffff8150c2cf
#2 [ffff881024ccfd50] __mutex_lock_slowpath at ffffffff8150cee7
#3 [ffff881024ccfdc0] mutex_lock at ffffffff8150cdeb
#4 [ffff881024ccfde0] rdma_destroy_id at ffffffffa022a027 [rdma_cm]
#5 [ffff881024ccfe10] rds_ib_laddr_check at ffffffffa0357857 [rds_rdma]
#6 [ffff881024ccfe50] rds_trans_get_preferred at ffffffffa0324c2a [rds]
#7 [ffff881024ccfe80] rds_bind at ffffffffa031d690 [rds]
#8 [ffff881024ccfeb0] sys_bind at ffffffff8142a670
PID: 45659 PID: 47039
rds_ib_laddr_check
/* create id_priv with a null event_handler */
rdma_create_id
rdma_bind_addr
cma_acquire_dev
/* add id_priv to cma_dev->id_list */
cma_attach_to_dev
cma_ndev_work_handler
/* event_hanlder is null */
id_priv->id.event_handler
Signed-off-by: Guanglei Li <guanglei.li-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Honglei Wang <honglei.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Junxiao Bi <junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Yanjun Zhu <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Acked-by: Santosh Shilimkar <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
net/rds/ib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/rds/ib.c b/net/rds/ib.c
index b2a5067..ff0c980 100644
--- a/net/rds/ib.c
+++ b/net/rds/ib.c
@@ -345,7 +345,8 @@ static int rds_ib_laddr_check(struct net *net, __be32 addr)
/* Create a CMA ID and try to bind it. This catches both
* IB and iWARP capable NICs.
*/
- cm_id = rdma_create_id(&init_net, NULL, NULL, RDMA_PS_TCP, IB_QPT_RC);
+ cm_id = rdma_create_id(&init_net, rds_rdma_cm_event_handler,
+ NULL, RDMA_PS_TCP, IB_QPT_RC);
if (IS_ERR(cm_id))
return PTR_ERR(cm_id);
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] RDS: IB: Fix null pointer issue
2018-02-05 2:27 Guanglei Li
@ 2018-02-05 17:40 ` Doug Ledford
0 siblings, 0 replies; 4+ messages in thread
From: Doug Ledford @ 2018-02-05 17:40 UTC (permalink / raw)
To: Guanglei Li, santosh.shilimkar, linux-rdma, netdev
Cc: honglei.wang, junxiao.bi, yanjun.zhu
[-- Attachment #1: Type: text/plain, Size: 3225 bytes --]
On Mon, 2018-02-05 at 10:27 +0800, Guanglei Li wrote:
> Scenario:
> 1. Port down and do fail over
> 2. Ap do rds_bind syscall
>
> PID: 47039 TASK: ffff89887e2fe640 CPU: 47 COMMAND: "kworker/u:6"
> #0 [ffff898e35f159f0] machine_kexec at ffffffff8103abf9
> #1 [ffff898e35f15a60] crash_kexec at ffffffff810b96e3
> #2 [ffff898e35f15b30] oops_end at ffffffff8150f518
> #3 [ffff898e35f15b60] no_context at ffffffff8104854c
> #4 [ffff898e35f15ba0] __bad_area_nosemaphore at ffffffff81048675
> #5 [ffff898e35f15bf0] bad_area_nosemaphore at ffffffff810487d3
> #6 [ffff898e35f15c00] do_page_fault at ffffffff815120b8
> #7 [ffff898e35f15d10] page_fault at ffffffff8150ea95
> [exception RIP: unknown or invalid address]
> RIP: 0000000000000000 RSP: ffff898e35f15dc8 RFLAGS: 00010282
> RAX: 00000000fffffffe RBX: ffff889b77f6fc00 RCX:ffffffff81c99d88
> RDX: 0000000000000000 RSI: ffff896019ee08e8 RDI:ffff889b77f6fc00
> RBP: ffff898e35f15df0 R8: ffff896019ee08c8 R9:0000000000000000
> R10: 0000000000000400 R11: 0000000000000000 R12:ffff896019ee08c0
> R13: ffff889b77f6fe68 R14: ffffffff81c99d80 R15: ffffffffa022a1e0
> ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
> #8 [ffff898e35f15dc8] cma_ndev_work_handler at ffffffffa022a228 [rdma_cm]
> #9 [ffff898e35f15df8] process_one_work at ffffffff8108a7c6
> #10 [ffff898e35f15e58] worker_thread at ffffffff8108bda0
> #11 [ffff898e35f15ee8] kthread at ffffffff81090fe6
>
> PID: 45659 TASK: ffff880d313d2500 CPU: 31 COMMAND: "oracle_45659_ap"
> #0 [ffff881024ccfc98] __schedule at ffffffff8150bac4
> #1 [ffff881024ccfd40] schedule at ffffffff8150c2cf
> #2 [ffff881024ccfd50] __mutex_lock_slowpath at ffffffff8150cee7
> #3 [ffff881024ccfdc0] mutex_lock at ffffffff8150cdeb
> #4 [ffff881024ccfde0] rdma_destroy_id at ffffffffa022a027 [rdma_cm]
> #5 [ffff881024ccfe10] rds_ib_laddr_check at ffffffffa0357857 [rds_rdma]
> #6 [ffff881024ccfe50] rds_trans_get_preferred at ffffffffa0324c2a [rds]
> #7 [ffff881024ccfe80] rds_bind at ffffffffa031d690 [rds]
> #8 [ffff881024ccfeb0] sys_bind at ffffffff8142a670
>
> PID: 45659 PID: 47039
> rds_ib_laddr_check
> /* create id_priv with a null event_handler */
> rdma_create_id
> rdma_bind_addr
> cma_acquire_dev
> /* add id_priv to cma_dev->id_list */
> cma_attach_to_dev
> cma_ndev_work_handler
> /* event_hanlder is null */
> id_priv->id.event_handler
>
> Signed-off-by: Guanglei Li <guanglei.li@oracle.com>
> Signed-off-by: Honglei Wang <honglei.wang@oracle.com>
> Reviewed-by: Junxiao Bi <junxiao.bi@oracle.com>
> Reviewed-by: Yanjun Zhu <yanjun.zhu@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
RDS patches normally go through Dave's tree, so for the RDMA aspects of
this patch:
Acked-by: Doug Ledford <dledford@redhat.com>
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3] RDS: IB: Fix null pointer issue
@ 2018-02-06 2:43 Guanglei Li
2018-02-06 16:44 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Guanglei Li @ 2018-02-06 2:43 UTC (permalink / raw)
To: davem, netdev; +Cc: guanglei.li
Scenario:
1. Port down and do fail over
2. Ap do rds_bind syscall
PID: 47039 TASK: ffff89887e2fe640 CPU: 47 COMMAND: "kworker/u:6"
#0 [ffff898e35f159f0] machine_kexec at ffffffff8103abf9
#1 [ffff898e35f15a60] crash_kexec at ffffffff810b96e3
#2 [ffff898e35f15b30] oops_end at ffffffff8150f518
#3 [ffff898e35f15b60] no_context at ffffffff8104854c
#4 [ffff898e35f15ba0] __bad_area_nosemaphore at ffffffff81048675
#5 [ffff898e35f15bf0] bad_area_nosemaphore at ffffffff810487d3
#6 [ffff898e35f15c00] do_page_fault at ffffffff815120b8
#7 [ffff898e35f15d10] page_fault at ffffffff8150ea95
[exception RIP: unknown or invalid address]
RIP: 0000000000000000 RSP: ffff898e35f15dc8 RFLAGS: 00010282
RAX: 00000000fffffffe RBX: ffff889b77f6fc00 RCX:ffffffff81c99d88
RDX: 0000000000000000 RSI: ffff896019ee08e8 RDI:ffff889b77f6fc00
RBP: ffff898e35f15df0 R8: ffff896019ee08c8 R9:0000000000000000
R10: 0000000000000400 R11: 0000000000000000 R12:ffff896019ee08c0
R13: ffff889b77f6fe68 R14: ffffffff81c99d80 R15: ffffffffa022a1e0
ORIG_RAX: ffffffffffffffff CS: 0010 SS: 0018
#8 [ffff898e35f15dc8] cma_ndev_work_handler at ffffffffa022a228 [rdma_cm]
#9 [ffff898e35f15df8] process_one_work at ffffffff8108a7c6
#10 [ffff898e35f15e58] worker_thread at ffffffff8108bda0
#11 [ffff898e35f15ee8] kthread at ffffffff81090fe6
PID: 45659 TASK: ffff880d313d2500 CPU: 31 COMMAND: "oracle_45659_ap"
#0 [ffff881024ccfc98] __schedule at ffffffff8150bac4
#1 [ffff881024ccfd40] schedule at ffffffff8150c2cf
#2 [ffff881024ccfd50] __mutex_lock_slowpath at ffffffff8150cee7
#3 [ffff881024ccfdc0] mutex_lock at ffffffff8150cdeb
#4 [ffff881024ccfde0] rdma_destroy_id at ffffffffa022a027 [rdma_cm]
#5 [ffff881024ccfe10] rds_ib_laddr_check at ffffffffa0357857 [rds_rdma]
#6 [ffff881024ccfe50] rds_trans_get_preferred at ffffffffa0324c2a [rds]
#7 [ffff881024ccfe80] rds_bind at ffffffffa031d690 [rds]
#8 [ffff881024ccfeb0] sys_bind at ffffffff8142a670
PID: 45659 PID: 47039
rds_ib_laddr_check
/* create id_priv with a null event_handler */
rdma_create_id
rdma_bind_addr
cma_acquire_dev
/* add id_priv to cma_dev->id_list */
cma_attach_to_dev
cma_ndev_work_handler
/* event_hanlder is null */
id_priv->id.event_handler
Signed-off-by: Guanglei Li <guanglei.li@oracle.com>
Signed-off-by: Honglei Wang <honglei.wang@oracle.com>
Reviewed-by: Junxiao Bi <junxiao.bi@oracle.com>
Reviewed-by: Yanjun Zhu <yanjun.zhu@oracle.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Acked-by: Doug Ledford <dledford@redhat.com>
---
net/rds/ib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/rds/ib.c b/net/rds/ib.c
index b2a5067..ff0c980 100644
--- a/net/rds/ib.c
+++ b/net/rds/ib.c
@@ -345,7 +345,8 @@ static int rds_ib_laddr_check(struct net *net, __be32 addr)
/* Create a CMA ID and try to bind it. This catches both
* IB and iWARP capable NICs.
*/
- cm_id = rdma_create_id(&init_net, NULL, NULL, RDMA_PS_TCP, IB_QPT_RC);
+ cm_id = rdma_create_id(&init_net, rds_rdma_cm_event_handler,
+ NULL, RDMA_PS_TCP, IB_QPT_RC);
if (IS_ERR(cm_id))
return PTR_ERR(cm_id);
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] RDS: IB: Fix null pointer issue
2018-02-06 2:43 [PATCH v3] RDS: IB: Fix null pointer issue Guanglei Li
@ 2018-02-06 16:44 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2018-02-06 16:44 UTC (permalink / raw)
To: guanglei.li; +Cc: netdev
From: Guanglei Li <guanglei.li@oracle.com>
Date: Tue, 6 Feb 2018 10:43:21 +0800
> Scenario:
> 1. Port down and do fail over
> 2. Ap do rds_bind syscall
...
> PID: 45659 PID: 47039
> rds_ib_laddr_check
> /* create id_priv with a null event_handler */
> rdma_create_id
> rdma_bind_addr
> cma_acquire_dev
> /* add id_priv to cma_dev->id_list */
> cma_attach_to_dev
> cma_ndev_work_handler
> /* event_hanlder is null */
> id_priv->id.event_handler
>
> Signed-off-by: Guanglei Li <guanglei.li@oracle.com>
> Signed-off-by: Honglei Wang <honglei.wang@oracle.com>
> Reviewed-by: Junxiao Bi <junxiao.bi@oracle.com>
> Reviewed-by: Yanjun Zhu <yanjun.zhu@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> Acked-by: Doug Ledford <dledford@redhat.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-06 16:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-06 2:43 [PATCH v3] RDS: IB: Fix null pointer issue Guanglei Li
2018-02-06 16:44 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2018-02-05 2:27 Guanglei Li
2018-02-05 17:40 ` Doug Ledford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).