From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
linux-arm-kernel@lists.infradead.org,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-samsung-soc@vger.kernel.org,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask
Date: Tue, 6 Feb 2018 09:28:56 +0100 [thread overview]
Message-ID: <20180206082856.qx4pj7of36yytetc@ninjato> (raw)
In-Reply-To: <CAMuHMdWnV17DCxr71k6n3w+5jPtQmeuPugr58xadq9U_qchJnQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
> I found two more using "git grep 'define.*0x[0-9a-f]* < '":
I added '[0-9]\+' at the end of the regex to reduce the number of false
positives...
> drivers/net/can/m_can/m_can.c:#define RXFC_FWM_MASK (0x7f < RXFC_FWM_SHIFT)
> drivers/usb/gadget/udc/goku_udc.h:#define INT_EPnNAK(n)
> (0x00100 < (n)) /* 0 < n < 4 */
... but you found those two true positives in there. Nice, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-06 8:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 20:09 [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask Wolfram Sang
2018-02-05 20:10 ` [PATCH 4/4] net: amd-xgbe: " Wolfram Sang
2018-02-05 22:35 ` Tom Lendacky
2018-02-06 16:25 ` David Miller
2018-02-06 8:20 ` [PATCH 0/4] tree-wide: " Geert Uytterhoeven
2018-02-06 8:28 ` Wolfram Sang [this message]
2018-02-06 13:10 ` Dan Carpenter
2018-02-06 13:15 ` Julia Lawall
2018-02-06 13:23 ` Dan Carpenter
2018-02-06 13:40 ` Julia Lawall
2018-02-06 13:53 ` Wolfram Sang
2018-02-06 13:54 ` Julia Lawall
2018-02-06 13:57 ` Wolfram Sang
2018-02-06 13:59 ` Dan Carpenter
2018-02-06 14:08 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206082856.qx4pj7of36yytetc@ninjato \
--to=wsa@the-dreams.de \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox