From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Westphal Subject: Re: xfrm, ip tunnel: non released device reference upon device unregistration Date: Tue, 6 Feb 2018 14:15:09 +0100 Message-ID: <20180206131509.GA14261@breakpoint.cc> References: <20180204132118.6fef9bf0@jimi> <20180206125624.GE15427@breakpoint.cc> <20180206130937.blxbrhmkpe3kt6lh@gauss3.secunet.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Florian Westphal , Eyal Birger , netdev@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, shmulik@metanetworks.com To: Steffen Klassert Return-path: Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:34364 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752015AbeBFNSR (ORCPT ); Tue, 6 Feb 2018 08:18:17 -0500 Content-Disposition: inline In-Reply-To: <20180206130937.blxbrhmkpe3kt6lh@gauss3.secunet.de> Sender: netdev-owner@vger.kernel.org List-ID: Steffen Klassert wrote: > I gave the patch a quick try, but still I get this: > > unregister_netdevice: waiting for dummy1 to become free. Usage count = 2 Was that with Eyals setup or the bridge one I posted? If it was Eyals setup, its possible the patch missed hookup to whatever tunnel infra is used (the setup I used has ipip tunnel, everything is ipv4). Also, perhaps it would be best to not bother with checking the device in question at all and unconditionally put device reference of all the dst_caches. With setups that have e.g. 1k devices going down per second (ppp dialin and the like) doing the full search for every notify event would be rather expensive.