From: Richard Cochran <richardcochran@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: jeffrey.t.kirsher@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON
Date: Tue, 6 Feb 2018 13:06:53 -0800 [thread overview]
Message-ID: <20180206210653.qjqmbxyqsdw43t3w@localhost> (raw)
In-Reply-To: <20180206194759.26991-1-christophe.jaillet@wanadoo.fr>
On Tue, Feb 06, 2018 at 08:47:59PM +0100, Christophe JAILLET wrote:
> 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask.
> The modified code should behave the same, because HWTSTAMP_TX_ON is 1
> and no other possible values of 'tx_type' would match the test.
> However, this is more future-proof, should other values be allowed one day.
Nice catch, and I am going to introduce more tx_type values soon.
Thanks,
Richard
next prev parent reply other threads:[~2018-02-06 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 19:47 [PATCH] igb: Fix a test with HWTSTAMP_TX_ON Christophe JAILLET
2018-02-06 21:06 ` Richard Cochran [this message]
2018-02-13 20:54 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206210653.qjqmbxyqsdw43t3w@localhost \
--to=richardcochran@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox