* [PATCH net] net/ipv6: Handle reject routes with onlink flag
@ 2018-02-06 20:14 David Ahern
2018-02-08 2:52 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: David Ahern @ 2018-02-06 20:14 UTC (permalink / raw)
To: netdev; +Cc: davem, David Ahern
Verification of nexthops with onlink flag need to handle unreachable
routes. The lookup is only intended to validate the gateway address
is not a local address and if the gateway resolves the egress device
must match the given device. Hence, hitting any default reject route
is ok.
Fixes: fc1e64e1092f ("net/ipv6: Add support for onlink flag")
Signed-off-by: David Ahern <dsahern@gmail.com>
---
net/ipv6/route.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index fb2d251c0500..69c43d289c69 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2488,7 +2488,8 @@ static int ip6_route_check_nh_onlink(struct net *net,
err = 0;
grt = ip6_nh_lookup_table(net, cfg, gw_addr, tbid, 0);
if (grt) {
- if (grt->rt6i_flags & flags || dev != grt->dst.dev) {
+ if (!grt->dst.error &&
+ (grt->rt6i_flags & flags || dev != grt->dst.dev)) {
NL_SET_ERR_MSG(extack, "Nexthop has invalid gateway");
err = -EINVAL;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net/ipv6: Handle reject routes with onlink flag
2018-02-06 20:14 [PATCH net] net/ipv6: Handle reject routes with onlink flag David Ahern
@ 2018-02-08 2:52 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-02-08 2:52 UTC (permalink / raw)
To: dsahern; +Cc: netdev
From: David Ahern <dsahern@gmail.com>
Date: Tue, 6 Feb 2018 12:14:12 -0800
> Verification of nexthops with onlink flag need to handle unreachable
> routes. The lookup is only intended to validate the gateway address
> is not a local address and if the gateway resolves the egress device
> must match the given device. Hence, hitting any default reject route
> is ok.
>
> Fixes: fc1e64e1092f ("net/ipv6: Add support for onlink flag")
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-08 2:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-06 20:14 [PATCH net] net/ipv6: Handle reject routes with onlink flag David Ahern
2018-02-08 2:52 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).