From: David Miller <davem@davemloft.net>
To: ilyal@mellanox.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, kafai@fb.com,
borisp@mellanox.com
Subject: Re: [PATCH v3 1/1] tcp: Honor the eor bit in tcp_mtu_probe
Date: Thu, 08 Feb 2018 14:37:50 -0500 (EST) [thread overview]
Message-ID: <20180208.143750.1594644041832386882.davem@davemloft.net> (raw)
In-Reply-To: <20180207131311.123540-1-ilyal@mellanox.com>
From: Ilya Lesokhin <ilyal@mellanox.com>
Date: Wed, 7 Feb 2018 15:13:11 +0200
> +static bool tcp_can_coalesce_send_queue_head(struct sock *sk, int len)
> +{
> + struct sk_buff *skb, *next;
> +
> + skb = tcp_send_head(sk);
> + tcp_for_write_queue_from_safe(skb, next, sk)
> + {
Please format tcp_for_write_queue_from_safe() uses like a real for loop,
meaning that the openning curly braces go on the same line as the
tcp_for_write_queue_from_safe() statement.
Thank you.
prev parent reply other threads:[~2018-02-08 19:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-07 13:13 [PATCH v3 1/1] tcp: Honor the eor bit in tcp_mtu_probe Ilya Lesokhin
2018-02-08 19:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180208.143750.1594644041832386882.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=borisp@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=ilyal@mellanox.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).