From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v3 1/1] tcp: Honor the eor bit in tcp_mtu_probe
Date: Thu, 08 Feb 2018 14:37:50 -0500 (EST)
Message-ID: <20180208.143750.1594644041832386882.davem@davemloft.net>
References: <20180207131311.123540-1-ilyal@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, kafai@fb.com,
        borisp@mellanox.com
To: ilyal@mellanox.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:48442 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751094AbeBHThw (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 8 Feb 2018 14:37:52 -0500
In-Reply-To: <20180207131311.123540-1-ilyal@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Ilya Lesokhin <ilyal@mellanox.com>
Date: Wed,  7 Feb 2018 15:13:11 +0200

> +static bool tcp_can_coalesce_send_queue_head(struct sock *sk, int len)
> +{
> +	struct sk_buff *skb, *next;
> +
> +	skb = tcp_send_head(sk);
> +	tcp_for_write_queue_from_safe(skb, next, sk)
> +	{

Please format tcp_for_write_queue_from_safe() uses like a real for loop,
meaning that the openning curly braces go on the same line as the
tcp_for_write_queue_from_safe() statement.

Thank you.